appDisplay: Stop using toggle-mode with folder icons

This is essentially a left-over from the original folder design, dating
all the way back to commit 6e3e2d9 in 2013.

It no longer makes much sense with the current design iteration, where
we pretend that the icon pops out of the grid and becomes the dialog
(i.e. we hide the icon and zoom out the dialog from its position).

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4114>

diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index e52278cbabf690c9fa68ff1a793850233bdb5a6c..20c133d7f5f7314431f044d4df20c92eab8095c4 100644 (file)
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -2276,7 +2276,6 @@ export const FolderIcon = GObject.registerClass({
         super._init({
             style_class: 'overview-tile app-folder',
             button_mask: St.ButtonMask.ONE,
-            toggle_mode: true,
             can_focus: true,
         }, global.settings.is_writable('app-picker-layout'));
         this._id = id;
@@ -2438,9 +2437,6 @@ export const FolderIcon = GObject.registerClass({
                     mode,
                     delay: isOpen ? 0 : FOLDER_DIALOG_ANIMATION_TIME - duration,
                 });
-
-                if (!isOpen)
-                    this.checked = false;
             });
         }
     }